Add Mode 1/2 option for LPS28DFW sensor with SD card persistence #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Todd (@thebrownhobbit-commits ), Excellent. Many thanks for the contribution! I'm away from my desk for a few days; I will take a look early next week. Thanks again, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theses modifications allow for the user to select either Mode 1 (260-1260 hPa) or Mode 2 (260-4000 hPa) for the LPS28DFW Digital Barometer.
The mode change has been routed through the menu configurations, the Qwiic Device autodetection and storage on the SD card via nvm.ino.
I have tried my best to stay in line with they way the code currently functions including NOT storing the option to the onboard eeprom memory. this means if the user power cycles the OLA without an SD card present, it will always revert back to mode 1.
ERROR/Concern - the ST spec sheet lists the mode 2 range for the pressure sensor to be 260-4060 hPA however the libraries are setup for 260-4000 hPa. I have used the 260-4000 hPa ranges. If the libraries are adjusted, please find and replace 4000 with 4060 throughout.
PLEASE NOTE this is my first contribution to public SW work and I am keen on code review, feedback, testing and verifications by others.